feat: 오토레이아웃 편의 Anchor 함수 작성 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyxxn
commented
Nov 8, 2024
Comment on lines
+122
to
+125
| top: view.safeAreaLayoutGuide.topAnchor, | ||
| leading: view.leadingAnchor, | ||
| bottom: view.safeAreaLayoutGuide.bottomAnchor, | ||
| trailing: view.trailingAnchor |
There was a problem hiding this comment.
top과 bottom은 safeAreaLayoutGuide로 했습니당
괜찮을까요 ??
Closed
k2645
approved these changes
Nov 9, 2024
Comment on lines
+68
to
+78
| func setHorizontal(view: UIView, constant: CGFloat) { | ||
| self.translatesAutoresizingMaskIntoConstraints = false | ||
| self.setLeading(anchor: view.leadingAnchor, constant: constant) | ||
| self.setTrailing(anchor: view.trailingAnchor, constant: constant) | ||
| } | ||
|
|
||
| func setHorizontal(layoutGuide: UILayoutGuide, constant: CGFloat) { | ||
| self.translatesAutoresizingMaskIntoConstraints = false | ||
| self.setLeading(anchor: layoutGuide.leadingAnchor, constant: constant) | ||
| self.setTrailing(anchor: layoutGuide.trailingAnchor, constant: constant) | ||
| } |
There was a problem hiding this comment.
P3: 위 두 함수는 각각 어떻게 다른건가요?? 레이아웃 가이드만 넣어야하고, UIView만 넣어야하는 경우가 각각 따로 있나요??
There was a problem hiding this comment.
아래 코드를 의도하고 만들긴 했습니다 !
layoutGuide의 경우 불 필요할까요 ??
titleLabel.setVertical(layoutGuide: view.safeAreaLayoutGuide, constant: 20)
or
titleLabel.setVertical(view: view, constant: 20)There was a problem hiding this comment.
옹 저런 경우가 있을 수 있겠군요 .ᐟ.ᐟ 저는 저런 이유라면 남겨도 될 것 같다는 의견입니다 .ᐟ.ᐟ
MemorialHouse/MHPresentation/MHPresentation/Source/Extensions/UIView+Anchor.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: 00me <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
📒 리뷰 노트
Before
After